On 10/4/24 2:33 AM, Angelo Dureghello wrote: > Hi Rob, > > On 03.10.2024 18:34, Rob Herring (Arm) wrote: >> >> On Thu, 03 Oct 2024 19:29:00 +0200, Angelo Dureghello wrote: >>> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >>> >>> Add a new compatible and related bindigns for the fpga-based >>> "ad3552r" AXI IP core, a variant of the generic AXI DAC IP. >>> >>> The AXI "ad3552r" IP is a very similar HDL (fpga) variant of the >>> generic AXI "DAC" IP, intended to control ad3552r and similar chips, >>> mainly to reach high speed transfer rates using a QSPI DDR >>> (dobule-data-rate) interface. >>> >>> The ad3552r device is defined as a child of the AXI DAC, that in >>> this case is acting as an SPI controller. >>> >>> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/iio/dac/adi,axi-dac.yaml | 49 +++++++++++++++++++++- >>> 1 file changed, 48 insertions(+), 1 deletion(-) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: spi-max-frequency: 66000000 is greater than the maximum of 30000000 >> from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml# I think this error is just due to patch ordering. The patch "dt-bindings: iio: dac: ad3552r: fix maximum spi speed" should come before this one. (In general, it is always best to put fixes first anyway.) >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: 'io-backends' does not match any of the regexes: '^channel@([0-1])$', 'pinctrl-[0-9]+' I've seen this pinctrl error pop up a few other times. I don't really understand it since none of the bindings involved reference pinctrl. Maybe an issue in the tooling? >> from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml# >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241003-wip-bl-ad3552r-axi-v0-iio-testing-v4-3-ceb157487329@xxxxxxxxxxxx >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > before sending the patchset i did > > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > CHKDT Documentation/devicetree/bindings > LINT Documentation/devicetree/bindings > DTC [C] Documentation/devicetree/bindings/iio/dac/adi,ad3552r.example.dtb > > no issues. > How can i detect the issue so ? > > Thanks,
