On 04/10/2024 10:41, Andreas Kemnade wrote: > Am Fri, 4 Oct 2024 10:24:32 +0300 > schrieb Roger Quadros <rogerq@xxxxxxxxxx>: > >> On 01/10/2024 00:30, Andreas Kemnade wrote: >>> To properly have things running after cold boot, define >>> GPIO regulators. Naming is based on board file. >>> >>> In the vendor kernel they are enabled in a function >>> called bt2ws_dcdc_init() if the system is not booted just >>> to charge the battery. >>> >>> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> >>> --- >>> .../boot/dts/ti/omap/omap4-epson-embt2ws.dts | 73 >>> +++++++++++++++++++ 1 file changed, 73 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts >>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index >>> 339e52ba3614..d6b0abba19f6 100644 --- >>> a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++ >>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -29,6 +29,42 >>> @@ backlight-right { power-supply = <&unknown_supply>; >>> }; >>> >>> + cb_v18: cb-v18 { >> >> https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#generic-names-recommendation >> >> >> So regulator@n >> where n is some index if it can't be address. >> > No, no @n. The above link says: "If the node has no reg property, the > @unit-address must be omitted and the node-name alone differentiates > the node from other nodes at the same level in the tree." So > probably regulator-cb-v18. Yes, I agree. -- cheers, -roger