On 04/10/2024 02:00, Rosen Penev wrote: > nvmem-cells are deprecated and replaced with nvmem-layout. For these > examples, replace. They're not relevant to the main point of the > document anyway. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx> > --- > .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- > .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- > 2 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > index 1c2b4e780ca9..8ae149534b23 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > @@ -45,17 +45,20 @@ examples: > compatible = "qcom,smem-part"; > > partition-art { > - compatible = "nvmem-cells"; > - #address-cells = <1>; > - #size-cells = <1>; > label = "0:art"; > > - macaddr_art_0: macaddr@0 { > - reg = <0x0 0x6>; > - }; > + nvmem-layout { > + compatible = "fixed-layout"; This does not look right - the binding still expects nvmem-cells. I wonder how does the nvmem-cells.yaml work if the compatible is being removed so it is not being selected. Best regards, Krzysztof
