On 03/10/2024 18:49, Per-Daniel Olsson wrote:
> Add devicetree bindings for the OPT4060 RGBW color sensor.
>
> Signed-off-by: Per-Daniel Olsson <perdaniel.olsson@xxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Regulator that provides power to the sensor.
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,opt4060
This allOf does not make sense.
> + then:
> + properties:
> + interrupts:
> + maxItems: 1
You repeat the case.
> + else:
> + properties:
> + interrupts: false
This cannot happen.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + opt4060@44 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,opt4060";
> + reg = <0x44>;
Best regards,
Krzysztof
