On 03/10/2024 12:03, Jean-Baptiste Maneyrol wrote: > Hello Krzysztof, > > this is strange because I run b4 prep --check and was expecting it to run checkpatch on the patches. > > I am having trailing whitespaces errors, but not on the part I changed. It looks like these "spaces" that aren't even displayed correctly in an editor are introduced by git. > > Do you have any idea on this kind of issues? > > Thanks, > JB Not much details above, but anyway, I think that's `b4 prep --check` and I reproduced it on 0.14.2. Konstantin, `b4 prep --check` does not operate on patches, thus for example SoB checks are not working. Reproduce: 1. Download this patchset, create patches (git format-patch). 2. scripts/checkpatch.pl 0* - will report correctly errors. 3. b4 prep --check will say everything is fine. Expected: same errors about SoB. P.S. I would bugspray you, but not sure how does it work :) Best regards, Krzysztof > > ________________________________________ > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Thursday, October 3, 2024 09:45 > To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH 1/3] MAINTAINERS: iio: migrate invensense email address to tdk domain > > This Message Is From an External Sender > This message came from outside your organization. > > On 03/10/2024 09:37, Jean-Baptiste Maneyrol via B4 Relay wrote: >> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> >> >> InvenSense is part of TDK group. Update email address to use the >> TDK domain. > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. > > Best regards, > Krzysztof > Best regards, Krzysztof
