On Wed, Oct 02, 2024 at 05:26:13PM -0400, Frank Li wrote: > The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT > function function to parser interrupt-map. So it doesn't consider Double 'function'. > '#address-size' in parent interrupt controller, such as GIC. > > When dt-binding verify interrupt-map, item data matrix is spitted at > incorrect position. So cause below warning: > > arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: interrupt-controller@14: > interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], ... > is too short > > Reduce minItems to workaround this warning. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > .../bindings/interrupt-controller/fsl,ls-extirq.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > index 199b34fdbefc4..b52abfd3e19d4 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > @@ -85,10 +85,17 @@ allOf: > - fsl,ls1088a-extirq > - fsl,ls2080a-extirq > - fsl,lx2160a-extirq > +# The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT > +# function function to parser interrupt-map. So it doesn't consider > +# '#address-size' in parent interrupt controller, such as GIC. > +# > +# When dt-binding verify interrupt-map, item data matrix is spitted at > +# incorrect position. Reduce minItems to workaround this problem. > + > then: > properties: > interrupt-map: > - minItems: 12 > + minItems: 8 This should be restricted to compatibles in that driver, not to all. I assume that driver won't be corrected here because it would break the ABI, thus probably maxItems should be 8 as well. Best regards, Krzysztof
