On Wed, Oct 02, 2024 at 04:09:28PM +0200, Linus Walleij wrote:
> On Wed, Oct 2, 2024 at 2:10 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> > Option B: Switch usbhs_probe() from "renesas,enable" to "enable"
> > and add quirks to of_find_gpio_rename():
> >
> > #if IS_ENABLED(CONFIG_USB_RENESAS_USBHS)
> > /*
> > * The Renesas HS-USB DT bindings happened before
> > enable-gpios
> > * was established as a generic property
> > */
> > { "enable", "renesas,enable-gpio",
> > "renesas,rza1-usbhs" },
> (...)
>
> I would actually prefer this.
>
> > Option C: Add a generic "strip vendor prefix" fallback to
> > of_find_gpio():
>
> I understand the appeal, but the idea is for the quirks to be
> very specific (hence they are enabled only if specific
> drivers are compiled in) and not start to be helpful. Doing
> this would make any vendor,foo start to work and I don't like that
> at all: any such mechanism will invariably be abused.
+1
Unless there's a bunch more platforms coming, I'd just stick with this
patch (or even do nothing).
Rob
