On Wed, Oct 02, 2024 at 10:08:36AM +0200, Heiko Stübner wrote: > Hi, > > Am Dienstag, 1. Oktober 2024, 06:23:59 CEST schrieb Yao Zi: > > This clock type is similar to GATE, but doesn't allow rate setting, > > which presents on RK3528 platform. > > this definitly needs more explanation in the commit message. > > I.e. regular individual gates always set the CLK_SET_RATE_PARENT flag > because of course the gates themselfs cannot influence the rate. > > > But in general, I'm also not convinced yet. Yes if some driver tries to > change the rate on those, it may affect the parent rate, but that is also > true for the other individual gates. > > So what makes aclk_emmc (as GATE_NO_SET_RATE) more special than > "hclk_emmc" (as regular GATE). [Same for the other clocks of course] . > > > So this either needs more explanation, or for the sake of simplicity > use regular GATE for now for those and we revisit when it becomes > necessary. I agree that more digging is needed for GATE_NO_SET_RATE. If no obvious reason for adding a clock type could be found, will convert these clocks into general GATEs and give it a try. Cheers, Yao Zi
