On Wed, Oct 02, 2024 at 09:49:21AM +0100, Conor Dooley wrote: > On Tue, Oct 01, 2024 at 09:18:03PM +0000, Yao Zi wrote: > > On Tue, Oct 01, 2024 at 05:29:15PM +0100, Conor Dooley wrote: > > > On Tue, Oct 01, 2024 at 04:23:57AM +0000, Yao Zi wrote: > > > > + clock-names: > > > > + items: > > > > + - const: xin24m > > > > + - const: phy_50m_out > > > > > > Why is this input clock named "out"? clocks should be named after how > > > they're used in the IP in question, not the name of the source of that > > > clock in the SoC. > > > Without descriptions provided in the clocks property, it is hard to > > > understand what this second clock is for. > > > > Thanks for explaination, it should something like "clk_gmac0". > > So it is actually an input clock to the cru? Yes, phy module generates it, being parent of several CRU clocks. > I'd like to see an items list in the clocks property please, > describing what these clocks are. > > Also, "clk" is redundant, since these are all clocks, so drop that > from the name. Okay. Cheers, Yao Zi
