Re: [PATCH 06/13] Input: adp5589-keys: add support for fw properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2024-10-01 at 07:59 -0700, Dmitry Torokhov wrote:
> On Tue, Oct 01, 2024 at 03:41:37PM +0200, Nuno Sa wrote:
> > +
> > +	switch (cfg) {
> > +	case PIN_CONFIG_BIAS_PULL_UP:
> > +		fallthrough;
> > +	case PIN_CONFIG_BIAS_PULL_DOWN:
> > +		fallthrough;
> > +	case PIN_CONFIG_BIAS_DISABLE:
> > +		return adp5589_gpio_set_bias(kpad, pin, cfg);
> 
> I don't think you need to use "fallhrough" here, saying:
> 
> 	case PIN_CONFIG_BIAS_PULL_UP:
> 	case PIN_CONFIG_BIAS_PULL_DOWN:
> 	case PIN_CONFIG_BIAS_DISABLE:
> 		return adp5589_gpio_set_bias(kpad, pin, cfg);
> 
> should not result in any warnings.
> 
> Thanks.
> 

Arghh sure... Will do that in v2.

- Nuno Sá





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux