Hi,
On 01/10/2024 23:47, Miquel Raynal wrote:
> My understanding of the interrupts property is that it can either be:
> 1/ - TX
> 2/ - TX
> - RX
> 3/ - Common/combined.
>
> There are very little chances that either:
> - TX
> - Common/combined
> or even
> - TX
> - RX
> - Common/combined
> could be a thing.
For interrupt these are the valid onesÉ
- Common only
- TX and RX
- TX only
- RX only
The driver cuts this through by trying to request all and leaves it for
DT to specify the correct irqs.
Note: in case of common only, we still have RX+TX, TX only, RX only
operation, but that is just a side note.
>
> Looking at the interrupt-names definition (which uses oneOf instead of
> anyOf), it makes indeed little sense to use anyOf in the interrupts
> definition. I believe this is just a mistake, hence let's fix it.
>
> Fixes: 8be90641a0bb ("ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema")
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> ---
> .../devicetree/bindings/sound/davinci-mcasp-audio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> index 7735e08d35ba..ab3206ffa4af 100644
> --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> @@ -102,7 +102,7 @@ properties:
> default: 2
>
> interrupts:
> - anyOf:
> + oneOf:
> - minItems: 1
> items:
> - description: TX interrupt
--
Péter
