Hi Krzysztof,
krzk@xxxxxxxxxx wrote on Wed, 2 Oct 2024 08:34:44 +0200:
> On Tue, Oct 01, 2024 at 10:47:49PM +0200, Miquel Raynal wrote:
> > My understanding of the interrupts property is that it can either be:
> > 1/ - TX
> > 2/ - TX
> > - RX
> > 3/ - Common/combined.
> >
> > There are very little chances that either:
> > - TX
> > - Common/combined
> > or even
> > - TX
> > - RX
> > - Common/combined
> > could be a thing.
> >
> > Looking at the interrupt-names definition (which uses oneOf instead of
> > anyOf), it makes indeed little sense to use anyOf in the interrupts
> > definition. I believe this is just a mistake, hence let's fix it.
> >
> > Fixes: 8be90641a0bb ("ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema")
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> > ---
> > .../devicetree/bindings/sound/davinci-mcasp-audio.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> > index 7735e08d35ba..ab3206ffa4af 100644
> > --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> > +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
> > @@ -102,7 +102,7 @@ properties:
> > default: 2
> >
> > interrupts:
> > - anyOf:
> > + oneOf:
>
>
> You need to change interrupt-names as well.
interrupt-names is already using 'oneOf'!
The extended diff looks like that:
interrupts:
- anyOf:
+ oneOf:
- minItems: 1
items:
- description: TX interrupt
- description: RX interrupt
- items:
- description: common/combined interrupt
interrupt-names:
oneOf:
- minItems: 1
items:
- const: tx
- const: rx
- const: common
Thanks,
Miquèl
