The MediaTek DPI module is typically associated with one of the
following multimedia power domains:
- POWER_DOMAIN_DISPLAY
- POWER_DOMAIN_VDOSYS
- POWER_DOMAIN_MM
The specific power domain used varies depending on the SoC design.
These power domains are shared by multiple devices within the SoC.
In most cases, these power domains are enabled by other devices.
As a result, the DPI module of legacy SoCs often functions correctly
even without explicit configuration.
It is recommended to explicitly add the appropriate power domain
property to the DPI node in the device tree. Hence drop the
compatible checking for specific SoCs.
Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains")
Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
Signed-off-by: Pablo Sun <pablo.sun@xxxxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
---
.../display/mediatek/mediatek,dpi.yaml | 24 ++++++++-----------
1 file changed, 10 insertions(+), 14 deletions(-)
Changes for v2:
- Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag.
[1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@xxxxxxxxxxxx/
We still need this change to fix the 2 dtbs_check errors.
So keeps no change here.
Changes for v3:
- The origin patch is [2]
https://lore.kernel.org/all/20240926111449.9245-2-macpaul.lin@xxxxxxxxxxxx/
- Thanks for Conor's reminding, after MediaTek's internal discussion,
This patch v3 is the replacement of [2] v2.
Because the DPI module should has a explicit configuration with power domain.
- Drop Acked-by: tag since v3 is nearly a new patch for different approach.
Changes for v4:
- No change. Please help to review it again.
Changes for v5:
- Add missing Reviewed-by Tag from Krzysztof. Thanks.
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 3a82aec9021c..497c0eb4ed0b 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -63,6 +63,16 @@ properties:
- const: sleep
power-domains:
+ description: |
+ The MediaTek DPI module is typically associated with one of the
+ following multimedia power domains:
+ POWER_DOMAIN_DISPLAY
+ POWER_DOMAIN_VDOSYS
+ POWER_DOMAIN_MM
+ The specific power domain used varies depending on the SoC design.
+
+ It is recommended to explicitly add the appropriate power domain
+ property to the DPI node in the device tree.
maxItems: 1
port:
@@ -79,20 +89,6 @@ required:
- clock-names
- port
-allOf:
- - if:
- not:
- properties:
- compatible:
- contains:
- enum:
- - mediatek,mt6795-dpi
- - mediatek,mt8173-dpi
- - mediatek,mt8186-dpi
- then:
- properties:
- power-domains: false
-
additionalProperties: false
examples:
--
2.45.2
