Hi Linus, Thanks for the review. > > + __adsp_gpio_writew(port, BIT(offset), ADSP_PORT_REG_INEN_SET); > > Interrupt enable in the direction function? No thanks, poke the > interrupt registers in your irqchip if you make one (you currently > do not) in this case I'd say just disable all interrupts in probe() > using something like writew(base + ADSP_PORT_REG_INEN_SET, 0xffff) > and be done with it. > This will come up next time too so I wanted to mention that INEN here means "input enable." The PORT design has two registers for controlling pin direction, one to enable/disable output drivers (DIR) and one to enable input drivers (INEN) to be able to read the pin state from the gpio data register. If I recall the bare metal reference code toggled both but we can review if setting INEN for all pins and leaving it is acceptable as well to simplify things. Thanks, Greg -- Greg Malysa Timesys Corporation
