Hi Heiko,
On 9/30/24 11:01 PM, Heiko Stuebner wrote:
All Theobroma boards use a ti,amc6821 as fan controller.
It normally runs in an automatically controlled way and while it may be
possible to use it as part of a dt-based thermal management, this is
not yet specified in the binding, nor implemented in any kernel.
Newer boards already don't contain that #cooling-cells property, but
older ones do. So remove them for now, they can be re-added if thermal
integration gets implemented in the future.
Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Fixes: d99a02bcfa81 ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM")
Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Cc: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx>
Cc: Klaus Goger <klaus.goger@xxxxxxxxxxxxxxxxxxxxx>
This has been tripping the dt-binding check for a while and since we've
somehow not linked the fan controller to cpufreq for thermal throttling
just yet, this was essentially not used.
As far as I know, no DT we wrote for customers had that linked either,
so I think this is the most straightforward way to handle this rather
than documenting this properly in the dt-binding and making sure the
kernel driver actually supports it. As said, we can always revisit this
later on if need be.
Therefore,
Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
Thanks!
Quentin
