On 01/10/2024 09:05, Macpaul Lin wrote: > On 10/1/24 14:34, Krzysztof Kozlowski wrote: > > [snip] > >>> +description: | >>> + The communication between MT6358 and SoC is through Mediatek PMIC wrapper. >>> + For more detail, please visit Mediatek PMIC wrapper documentation. >>> + Must be a child node of PMIC wrapper. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - mediatek,mt6366-sound >>> + - mediatek,mt6358-sound >>> + const: mediatek,mt6358-sound >> >> This wasn't ever tested. > > Hum, I have indeed tested it with linux-next/master branch. > Ran dt_binding_check with dtschema trunk with this single file > but didn't get any warning or errors. > 'make dt_binding_check DT_SCHEMA_FILES=mt6358.yaml' > > Could you please help to paste the error log for me? > If there are new errors, I need to check if there is any > environment issue. Hm, I don't know, indeed Rob's does not report failure here, so my comment was not right. Syntax is unexpected or wrong - const with enum. Is this a list? If list then you duplicated compatible. Then maybe implicit oneOf? BTW, filenames are expected to match compatible. Best regards, Krzysztof
