Hi Krzysztof, I fully agree, some things got missed out; they were supposed to be addressed in the v9 patch. Not contesting that. My apologies. We are doing a code cleanup based on your inputs and previous comments. I will address everything. Warm regards, PK On Tue, Oct 1, 2024 at 12:03 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Mon, Sep 30, 2024 at 03:00:54PM +0530, Pavitrakumar M wrote: > > Add DT bindings related to the SPAcc driver for Documentation. > > DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto > > Engine is a crypto IP designed by Synopsys. > > > > Co-developed-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> > > Signed-off-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> > > Co-developed-by: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> > > Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> > > Acked-by: Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. > > Best regards, > Krzysztof >
