Il 27/09/24 14:29, Albert Jakieła ha scritto:
The MT8186 Chinchou/Chinchou360, also known as the Asus Chromebook CZ12/CZ11 Flip, is a clamshell or convertible device with touchscreen, stylus and extra buttons.
You have a typo in your commit title `mediate` -> `mediatek`
Signed-off-by: Albert Jakieła <jakiela@xxxxxxxxxx> --- Changes in v2: - PATCH 2/2: Remove sku2147483647, remove duplicate nodes, add model and remove uneccecery nodes from sound card. - Link to v1: https://lore.kernel.org/all/20240925080353.2362879-2-jakiela@xxxxxxxxxx/ --- arch/arm64/boot/dts/mediatek/Makefile | 3 + .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 + .../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++ .../mt8186-corsola-chinchou-sku16.dts | 28 ++ .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 432 ++++++++++++++++++ 5 files changed, 515 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
..snip..
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi new file mode 100644 index 000000000000..96cc3c267c20 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi @@ -0,0 +1,432 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2023 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola.dtsi" + +/ {
..snip..
+ +&sound { + status = "okay"; + + compatible = "mediatek,mt8186-mt6366-rt5650-sound";
Why did you keep the compatible string override?
+ model = "mt8186_rt5650"; +
Regards, Angelo