Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/09/2024 09:46, Vladimir Zapolskiy wrote:
Hello Krzysztof,

On 9/30/24 10:16, Krzysztof Kozlowski wrote:
On 25/09/2024 17:13, Depeng Shao wrote:
Hi Vladimir,

On 9/6/2024 11:56 PM, Vladimir Zapolskiy wrote:

+            compatible = "qcom,sm8550-camss";
+
+            reg = <0 0x0acb7000 0 0xd00>,
+                  <0 0x0acb9000 0 0xd00>,
+                  <0 0x0acbb000 0 0xd00>,
+                  <0 0x0acca000 0 0xa00>,
+                  <0 0x0acce000 0 0xa00>,
+                  <0 0x0acb6000 0 0x1000>,
+                  <0 0x0ace4000 0 0x2000>,
+                  <0 0x0ace6000 0 0x2000>,
+                  <0 0x0ace8000 0 0x2000>,
+                  <0 0x0acea000 0 0x2000>,
+                  <0 0x0acec000 0 0x2000>,
+                  <0 0x0acee000 0 0x2000>,
+                  <0 0x0acf0000 0 0x2000>,
+                  <0 0x0acf2000 0 0x2000>,
+                  <0 0x0ac62000 0 0xf000>,
+                  <0 0x0ac71000 0 0xf000>,
+                  <0 0x0ac80000 0 0xf000>,
+                  <0 0x0accb000 0 0x2800>,
+                  <0 0x0accf000 0 0x2800>;

Please sort the list above in numerical order, this will change positions
of "vfe_lite0", "vfe_lite1" etc.

Another note, since it's not possible to map less than a page, so I believe
it might make sense to align all sizes to 0x1000.


Sure, I previously sorted by the alphabetical order of reg_name.
I will update it based on your suggestion. And will also make sure the
align all sizes to 0x1000.

If I understood correctly, you want to change the order from existing
devices, so no. You are supposed to keep the same order, as much as
possible.

Please elaborate, what do you mean here by the "existing evices"?

The list is not sorted by reg values, I ask to sort the list by reg values.

--
Best wishes,
Vladimir

We always sort by address:

                camss: camss@ac5a000 {
                        compatible = "qcom,sc8280xp-camss";

                        reg = <0 0x0ac5a000 0 0x2000>,
                              <0 0x0ac5c000 0 0x2000>,
                              <0 0x0ac65000 0 0x2000>,
                              <0 0x0ac67000 0 0x2000>,
                              <0 0x0acaf000 0 0x4000>,
                              <0 0x0acb3000 0 0x1000>,
                              <0 0x0acb6000 0 0x4000>,
                              <0 0x0acba000 0 0x1000>,
                              <0 0x0acbd000 0 0x4000>,
                              <0 0x0acc1000 0 0x1000>,
                              <0 0x0acc4000 0 0x4000>,
                              <0 0x0acc8000 0 0x1000>,
                              <0 0x0accb000 0 0x4000>,
                              <0 0x0accf000 0 0x1000>,
                              <0 0x0acd2000 0 0x4000>,
                              <0 0x0acd6000 0 0x1000>,
                              <0 0x0acd9000 0 0x4000>,
                              <0 0x0acdd000 0 0x1000>,
                              <0 0x0ace0000 0 0x4000>,
                              <0 0x0ace4000 0 0x1000>;
                        reg-names = "csiphy2",
                                    "csiphy3",
                                    "csiphy0",
                                    "csiphy1",
                                    "vfe0",
                                    "csid0",
                                    "vfe1",
                                    "csid1",
                                    "vfe2",
                                    "csid2",
                                    "vfe_lite0",
                                    "csid0_lite",
                                    "vfe_lite1",
                                    "csid1_lite",
                                    "vfe_lite2",
                                    "csid2_lite",
                                    "vfe_lite3",
                                    "csid3_lite",
                                    "vfe3",
                                    "csid3";

This is the way.

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux