Hi,
On Sun, Sep 29, 2024 at 01:36:49AM GMT, Cristian Ciocaltea wrote:
> +static void dw_hdmi_qp_rockchip_encoder_enable(struct drm_encoder *encoder)
> +{
> + struct rockchip_hdmi_qp *hdmi = to_rockchip_hdmi_qp(encoder);
> + struct drm_crtc *crtc = encoder->crtc;
> + int rate;
> +
> + /* Unconditionally switch to TMDS as FRL is not yet supported */
> + gpiod_set_value(hdmi->enable_gpio, 1);
> +
> + if (crtc && crtc->state) {
> + clk_set_rate(hdmi->ref_clk,
> + crtc->state->adjusted_mode.crtc_clock * 1000);
Sorry, I should have seen it in your previous version, but the rate here
should be the TMDS character rate, not the pixel clock, right?
Once fixed,
Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>
Maxime
Attachment:
signature.asc
Description: PGP signature
