On Thu, Sep 26, 2024 at 05:22:11PM GMT, Dzmitry Sankouski wrote:
It would be much appreciated if we included "sdm845-starqltechn" in the
subject. That way it will help me when I try to write the pull request
later, and try to group sdm845 changes together...
> Add support for gpu and panel.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> ---
> Changes for v5:
> - fix label names
> ---
> arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> index 230e984b5ba3..f7cb09734d2f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> @@ -203,6 +203,52 @@ vib_pwm: pwm {
> };
> };
>
> +&gpu {
> + status = "okay";
> +
> + zap-shader {
> + memory-region = <&gpu_mem>;
> + firmware-name = "qcom/sdm845/starqltechn/a630_zap.mbn";
> + };
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + vdda-supply = <&vreg_l26a_1p2>;
> + status = "okay";
> +
> + panel@0 {
> + compatible = "samsung,s6e3ha8";
> + reg = <0>;
> + vci-supply = <&s2dos05_ldo4>;
> + vddr-supply = <&s2dos05_buck>;
> + vdd3-supply = <&s2dos05_ldo1>;
> + te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&sde_dsi_default &sde_te>;
> + pinctrl-1 = <&sde_dsi_suspend &sde_te>;
> + pinctrl-names = "default", "suspend";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> +&mdss_dsi0_out {
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&panel_in>;
> +};
> +
> +&mdss_dsi0_phy {
> + vdds-supply = <&vdda_mipi_dsi0_pll>;
> + status = "okay";
> +};
>
> &apps_rsc {
> regulators-0 {
> @@ -837,6 +883,27 @@ &tlmm {
> gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
> <85 4>; /* SPI (fingerprint reader) */
>
> + sde_dsi_default: sde-dsi-default-state {
I'd prefer we leave the "sde" out of here.
Also, 'sde' > 'sdc2', so in its current form this should be moved down a
bit.
Regards,
Bjorn
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-disable;
> + };
> +
> + sde_dsi_suspend: sde-dsi-suspend-state {
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + sde_te: sde-te-state {
> + pins = "gpio10";
> + function = "mdp_vsync";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> sdc2_clk_state: sdc2-clk-state {
> pins = "sdc2_clk";
> bias-disable;
>
> --
> 2.39.2
>
