Hi Igor, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Igor-Prusov/dt-bindings-vendor-prefixes-Add-NeoFidelity-Inc/20240925-230818 base: c7fbbb45ef78ff349d16923b516bc8667367d1a6 patch link: https://lore.kernel.org/r/20240925-ntp-amps-8918-8835-v3-6-e2459a8191a6%40salutedevices.com patch subject: [PATCH v3 6/6] ASoC: codecs: Add NeoFidelity NTP8835 codec config: alpha-randconfig-r072-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281054.DUTb5KxU-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202409281054.DUTb5KxU-lkp@xxxxxxxxx/ smatch warnings: sound/soc/codecs/ntp8835.c:431 ntp8835_i2c_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +431 sound/soc/codecs/ntp8835.c c4c94fd2babcb9 Igor Prusov 2024-09-25 412 static int ntp8835_i2c_probe(struct i2c_client *i2c) c4c94fd2babcb9 Igor Prusov 2024-09-25 413 { c4c94fd2babcb9 Igor Prusov 2024-09-25 414 struct ntp8835_priv *ntp8835; c4c94fd2babcb9 Igor Prusov 2024-09-25 415 struct regmap *regmap; c4c94fd2babcb9 Igor Prusov 2024-09-25 416 int ret; c4c94fd2babcb9 Igor Prusov 2024-09-25 417 c4c94fd2babcb9 Igor Prusov 2024-09-25 418 ntp8835 = devm_kzalloc(&i2c->dev, sizeof(*ntp8835), GFP_KERNEL); c4c94fd2babcb9 Igor Prusov 2024-09-25 419 if (!ntp8835) c4c94fd2babcb9 Igor Prusov 2024-09-25 420 return -ENOMEM; c4c94fd2babcb9 Igor Prusov 2024-09-25 421 c4c94fd2babcb9 Igor Prusov 2024-09-25 422 ntp8835->i2c = i2c; c4c94fd2babcb9 Igor Prusov 2024-09-25 423 c4c94fd2babcb9 Igor Prusov 2024-09-25 424 ntp8835->reset = devm_reset_control_get_shared(&i2c->dev, NULL); c4c94fd2babcb9 Igor Prusov 2024-09-25 425 if (IS_ERR(ntp8835->reset)) c4c94fd2babcb9 Igor Prusov 2024-09-25 426 return dev_err_probe(&i2c->dev, PTR_ERR(ntp8835->reset), c4c94fd2babcb9 Igor Prusov 2024-09-25 427 "Failed to get reset\n"); c4c94fd2babcb9 Igor Prusov 2024-09-25 428 c4c94fd2babcb9 Igor Prusov 2024-09-25 429 ret = reset_control_deassert(ntp8835->reset); c4c94fd2babcb9 Igor Prusov 2024-09-25 430 if (ret) c4c94fd2babcb9 Igor Prusov 2024-09-25 @431 return dev_err_probe(&i2c->dev, PTR_ERR(ntp8835->reset), PTR_ERR(ret) c4c94fd2babcb9 Igor Prusov 2024-09-25 432 "Failed to deassert reset\n"); c4c94fd2babcb9 Igor Prusov 2024-09-25 433 c4c94fd2babcb9 Igor Prusov 2024-09-25 434 dev_set_drvdata(&i2c->dev, ntp8835); c4c94fd2babcb9 Igor Prusov 2024-09-25 435 c4c94fd2babcb9 Igor Prusov 2024-09-25 436 ntp8835_reset_gpio(ntp8835); c4c94fd2babcb9 Igor Prusov 2024-09-25 437 c4c94fd2babcb9 Igor Prusov 2024-09-25 438 regmap = devm_regmap_init_i2c(i2c, &ntp8835_regmap); c4c94fd2babcb9 Igor Prusov 2024-09-25 439 if (IS_ERR(regmap)) c4c94fd2babcb9 Igor Prusov 2024-09-25 440 return dev_err_probe(&i2c->dev, PTR_ERR(regmap), c4c94fd2babcb9 Igor Prusov 2024-09-25 441 "Failed to allocate regmap\n"); c4c94fd2babcb9 Igor Prusov 2024-09-25 442 c4c94fd2babcb9 Igor Prusov 2024-09-25 443 ret = devm_snd_soc_register_component(&i2c->dev, &soc_component_ntp8835, c4c94fd2babcb9 Igor Prusov 2024-09-25 444 &ntp8835_dai, 1); c4c94fd2babcb9 Igor Prusov 2024-09-25 445 if (ret) c4c94fd2babcb9 Igor Prusov 2024-09-25 446 return dev_err_probe(&i2c->dev, ret, c4c94fd2babcb9 Igor Prusov 2024-09-25 447 "Failed to register component\n"); c4c94fd2babcb9 Igor Prusov 2024-09-25 448 c4c94fd2babcb9 Igor Prusov 2024-09-25 449 ntp8835->mclk = devm_clk_get_enabled(&i2c->dev, "mclk"); c4c94fd2babcb9 Igor Prusov 2024-09-25 450 if (IS_ERR(ntp8835->mclk)) c4c94fd2babcb9 Igor Prusov 2024-09-25 451 return dev_err_probe(&i2c->dev, PTR_ERR(ntp8835->mclk), "failed to get mclk\n"); c4c94fd2babcb9 Igor Prusov 2024-09-25 452 c4c94fd2babcb9 Igor Prusov 2024-09-25 453 return 0; c4c94fd2babcb9 Igor Prusov 2024-09-25 454 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki