Hi Krzysztof,
On 2024/9/27 17:52, Krzysztof Kozlowski wrote:
On 27/09/2024 09:59, Frank Wang wrote:
- clocks:
- maxItems: 1
+ clocks: true
- clock-names:
- const: phyclk
+ clock-names: true
For the third time, read the code I gave you. Do you see something like
this there? Why doing all the time something different than existing code?
Refer to the link you sent me that I must add minItems property for
clocks, just like the below codes:
@@ -35,7 +35,8 @@ properties:
const: 0
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
Yes, for all variable properties, so also names.
That can pass dt_binding and dtb checking, however, "clocks" is the
optional property for some old Rockchip PHYs, I am not sure is it right
to force set minItems as 1 .
If just keep maxItems, the dt_binding checking is failure.
Please specify the question you want to ask.
Q1: The "clocks" is an optional property for some old Rockchip PHYs, so
set "minItems: 1" likes the below, is this a suitable setting?
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3Q2: Do you want me to amend the code to like this?
clocks: minItems: 1 maxItems: 3 clock-names: minItems: 1 maxItems: 3
allOf: [...] - if: properties: compatible: contains: enum: -
rockchip,px30-usb2phy - rockchip,rk3128-usb2phy -
rockchip,rk3228-usb2phy - rockchip,rk3308-usb2phy -
rockchip,rk3328-usb2phy - rockchip,rk3366-usb2phy -
rockchip,rk3399-usb2phy - rockchip,rk3568-usb2phy -
rockchip,rk3588-usb2phy - rockchip,rv1108-usb2phy then: properties:
clocks: maxItems: 1 clock-names: const: phyclk - if: properties:
compatible: contains: enum: - rockchip,rk3576-usb2phy then: properties:
clocks: minItems: 3 maxItems: 3 clock-names: items: - const: phyclk -
const: aclk - const: aclk_slv
Best regards,
Frank
Best regards,
Krzysztof
