On Fri, Sep 27, 2024 at 01:51:40PM +0800, Moudy Ho wrote:
> From: Moudy Ho <moudy.ho@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> The display node in mt8195.dtsi was triggering a CHECK_DTBS error due
> to an excessively long 'clocks' property:
> display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long
>
> To resolve this issue, apply the limit by setting 'maxItems: 3' in MT8195
> additional condition.
>
> Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml")
> Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx>
Your SoB does not match.
Please run scripts/checkpatch.pl and fix reported warnings. Then please
run and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.
> --
> The purpose of this patch is to separate the corrections for
> MediaTek SPLIT CHECK_DTBS error from the original mailing list
> mentioned below:
> https://lore.kernel.org/all/20240924103156.13119-2-macpaul.lin@xxxxxxxxxxxx/
>
> Changes since v1:
> - Adding functional descriptions and quantity restrictions.
> ---
> .../bindings/display/mediatek/mediatek,split.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> index e4affc854f3d..bce1b8b866ce 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> @@ -57,6 +57,9 @@ properties:
> clocks:
> items:
> - description: SPLIT Clock
> + - description: HDMI RX Clock
> + - description: HDMI Metadata Clock
> + minItems: 1
>
> required:
> - compatible
> @@ -72,6 +75,9 @@ allOf:
> const: mediatek,mt8195-mdp3-split
>
> then:
> + properties:
> + clocks:
missing minItems
Missing constraints for all the variants.
Best regards,
Krzysztof
