> -----Original Message----- > From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> > Sent: Friday, September 27, 2024 2:29 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>; > patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley > <joel@xxxxxxxxx> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible > string of adm1272 > > [External Sender] > > [External Sender] > > On Fri, 2024-09-27 at 06:21 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: > > > > > -----Original Message----- > > > From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> > > > Sent: Friday, September 27, 2024 2:01 PM > > > To: Delphine_CC_Chiu/WYHQ/Wiwynn > <Delphine_CC_Chiu@xxxxxxxxxx>; > > > patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof > > > Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > > > Joel Stanley <joel@xxxxxxxxx> > > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>; > > > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > > > linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the > > > compatible string of adm1272 > > > > > > [External Sender] > > > > > > [External Sender] > > > > > > On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote: > > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx> > > > > > > > > Remove the redundant space in the compatible string of adm1272. > > > > > > In this case the space is not redundant, it's just incorrect, the > > > compatible string doesn't match any specified. Do you mind fixing the > wording? > > > > > Sure, I'll fixing the wording in v2. > > Thanks. > > > > > > > > > > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx> > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > > > > > Can you please add an appropriate Fixes: tag? > > > > > > Thanks, > > > > > > Andrew > > > > > Would like to ask where should I add the Fixes: tag? > > Should I add in the patch title like: > > Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of > > adm1272 > > > > Or should I add in the commit message? > > It goes in the trailer block above your Signed-off-by tag. It will be worth your > time to review the following documentation: > > - > https://urldefense.com/v3/__https://docs.kernel.org/process/5.Posting.html*p > atch-formatting-and-changelogs__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCF > m9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_GxdXBhSTrA > $ > - > https://urldefense.com/v3/__https://docs.kernel.org/process/submitting-patch > es.html*describe-your-changes__;Iw!!J63qqgXj!LdpKTr36YV5e4cCRly5lII5iCFm > 9zsnavi_vRueNWvNHGQ8SimCf-YfL14fxXTRL3Fxnkmid4VLDlGSY_Gxd0pKAYmU > $ > > The expected format and other details are described there. > > Thanks, > > Andrew Hi Andrew, Thanks for your information! I'll follow the format described in the document and send the v2 patch. Ricky
