On 26/09/24 18:37, Krzysztof Kozlowski wrote:
> On Thu, Sep 26, 2024 at 09:58:46AM +1200, Chris Packham wrote:
>> Add the I2C controllers that are part of the RTL9300 SoC.
>>
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> ---
>>
>> Notes:
>> Changes in v5:
>> - Update compatibles
>> Changes in v4:
>> - Skipped due to combining patch series
>> Changes in v3:
>> - None
>> Changes in v2:
>> - Use reg property
>>
>> arch/mips/boot/dts/realtek/rtl9302c.dtsi | 8 ++++++++
>> arch/mips/boot/dts/realtek/rtl930x.dtsi | 16 ++++++++++++++++
>> 2 files changed, 24 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/realtek/rtl9302c.dtsi b/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> index 80d9f407e758..56c35e8b8b62 100644
>> --- a/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> +++ b/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> @@ -5,3 +5,11 @@
>> &switch0 {
>> compatible = "realtek,rtl9302c-switch", "realtek,rtl9300-switch", "syscon", "simple-mfd";
>> };
>> +
>> +&i2c0 {
>> + compatible = "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c";
>> +};
>> +
>> +&i2c1 {
>> + compatible = "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c";
>> +};
>> diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> index 89b8854596cd..2fb8461af575 100644
>> --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> @@ -41,6 +41,22 @@ reboot@c {
>> reg = <0x0c 0x4>;
>> value = <0x01>;
>> };
>> +
>> + i2c0: i2c@36c {
>> + compatible = "realtek,rtl9300-i2c";
>> + reg = <0x36c 0x14>;
>> + status = "disabled";
> Usual convention is to have status the last. Maybe MIPS has different,
> so keep whatever is consistent in your case.
I'll send out a fixup patch that can be folded into this. Hopefully
Thomas can combine them at his end (or if there is a need for a v6 I can).
I'll probably have other series touching this file so if the fixup
doesn't make it now I can include it in a future series.
>
> Anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
>
