On 25/09/2024 23:07, Jiri Kosina wrote:
> On Wed, 25 Sep 2024, Krzysztof Kozlowski wrote:
>
>> This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID
>> Touchscreen") because it duplicates existing binding leadings to errors:
>>
>> goodix,gt7986u.example.dtb:
>> touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed:
>> ['goodix,gt7986u'] is too short
>> 'goodix,gt7375p' was expected
>>
>> This was reported on mailing list on 6th of September, but no reaction
>> happened from contributor or maintainer to fix it.
>>
>> Therefore let's drop binding which breaks and duplicates existing one.
>>
>> Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen")
>> Reported-by: Rob Herring <robh@xxxxxxxxxx>
>> Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@xxxxxxxxxxxxxx/
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> I've applied both patches now and will expedite them to Linus.
Thanks Jiri,
Charles,
If you ever receive a report about an issue in your patch, you should
respond to it and address it. Regardless whether it is on the lists only
or already merged.
If you do not respond to issues reported for your commits, it might
cause impression that you only care about getting your stuff into the
kernel and whatever after does not matter. As maintainer I would not
take more patches from you in such case, I bet other maintainers would
be reluctant to take them too.
Best regards,
Krzysztof
