Hi Mark: On Tue, Sep 24, 2024 at 3:19 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Tue, Sep 24, 2024 at 03:00:32PM +0800, Binbin Zhou wrote: > > > When the Codec is compiled into a module, we can't use > > snd_soc_of_get_dlc() to get the codec dai_name, use > > snd_soc_get_dai_name() instead. > > What is the issue with using snd_soc_of_get_dlc()? Shouldn't we fix the > helper instead? I'm very sorry for this part, I checked and tested it again and I should have over-modified it as well as the use of snd_soc_of_get_dlc() is correct. In fact, what's really being missed here is the assignment of snd_soc_dai_link.platforms->of_node, which causes component_empty for soc_dai_link_sanity_check(). I'll rewrite this part in the next patch set. Thanks. Binbin
