Hi Conor,
On 2024/9/25 0:11, Conor Dooley wrote:
On Tue, Sep 24, 2024 at 04:55:09PM +0800, Frank Wang wrote:
From: Frank Wang <frank.wang@xxxxxxxxxxxxxx>
Add compatible for the USB2 phy in the Rockchip RK3576 SoC.
Signed-off-by: Frank Wang <frank.wang@xxxxxxxxxxxxxx>
---
Changelog:
v2:
- Categorize clock names by oneOf keyword.
v1:
- https://patchwork.kernel.org/project/linux-phy/patch/20240923025326.10467-1-frank.wang@xxxxxxxxxxxxxx/
.../bindings/phy/rockchip,inno-usb2phy.yaml | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
index 5254413137c64..8af4e0f8637fc 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
@@ -20,6 +20,7 @@ properties:
- rockchip,rk3366-usb2phy
- rockchip,rk3399-usb2phy
- rockchip,rk3568-usb2phy
+ - rockchip,rk3576-usb2phy
- rockchip,rk3588-usb2phy
- rockchip,rv1108-usb2phy
@@ -34,10 +35,20 @@ properties:
const: 0
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
clock-names:
- const: phyclk
+ minItems: 1
+ maxItems: 3
clock-names isn't a required property, you can't allow jumbling the order
like this does without breaking the ABI. Why can't the new device have
phyclk in position 1?
I sent a draft changes in patch v1 comments which put the "phyclk" in
position 1, Krzysztof said I have messed the order, so I reorder them in v2.
Did I misunderstand? anyway, should the changes like the below?
@@ -34,10 +35,20 @@ properties:
const: 0
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
clock-names:
- const: phyclk
+ minItems: 1
+ maxItems: 3
+ items:
+ oneOf:
+ - description: PHY input reference clocks.
+ const: phyclk
+ - description: aclk for USB MMU.
+ const: aclk
+ - description: aclk_slv for USB MMU.
+ const: aclk_slv
BR.
Frank
+ items:
+ oneOf:
+ - description: aclk for USB MMU.
+ const: aclk
+ - description: aclk_slv for USB MMU.
+ const: aclk_slv
+ - description: PHY input reference clocks.
+ const: phyclk
assigned-clocks:
description:
@@ -143,6 +154,7 @@ allOf:
contains:
enum:
- rockchip,rk3568-usb2phy
+ - rockchip,rk3576-usb2phy
- rockchip,rk3588-usb2phy
then:
--
2.45.2
