Hi Krzysztof, On 24/09/24 20:51, Krzysztof Kozlowski wrote: > On 24/09/2024 10:39, Krzysztof Kozlowski wrote: >> On Tue, Sep 24, 2024 at 10:57:17AM +1200, Chris Packham wrote: >>> Add device tree schema for the Realtek switch. Currently the only >>> supported feature is the syscon-reboot which is needed to be able to >>> reboot the board. >>> >>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >>> --- >> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> > Unreviewed - it is incomplete! > > No, we said multiple times, you must send complete binding. Sending > pieces for review does not give us full picture and hides parts of the > controversial decisions. If you want to go this way, next time you will > get NAK when adding i2c@0-7 to parent binding. > Fair enough. I did already get myself tied in knots trying to juggle two dependent series. I thought I was making things easier to review by sending them in smaller chunks but obviously I'm holding things back that are relevant for context. So just to be clear, one binding in mfd that covers the reboot and i2c for the 4 variants? That's about as much as I can actually test driver wise. I could add the mdio and switch ports but I'm not at a point where I could really test them properly. I know the binding doesn't necessarily need code to be able to describe the hardware but it does run the risk that I might miss something in the binding that I need when I do get to the driver code. I also did want to say thanks for your patience. It may not seem like it but I really do appreciate your feedback and I do try to take it all on board. > Best regards, > Krzysztof >
