Am Dienstag, 24. September 2024, 10:55:10 CEST schrieb Frank Wang:
> From: William Wu <william.wu@xxxxxxxxxxxxxx>
>
> The RK3576 SoC has two independent USB2.0 PHYs, and
> each PHY has one port.
Can you please split the content into "converting to clk_bulk" (see
additional comment below) and "add rk3576" please?
That would make the patch a lot cleaner.
> @@ -376,6 +378,7 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)
> {
> struct device_node *node = rphy->dev->of_node;
> struct clk_init_data init;
> + struct clk *refclk = of_clk_get_by_name(node, "phyclk");
Doesn't this create an imbalance - with the missing put?
I think ideally just define clk_bulk_data structs for the
1-clock and 3-clock variant, attach that to the device-data
and then use the regular devm_clk_bulk_get ?
That way you can then retrieve the clock from that struct?
Thanks
Heiko
