On Tue, 24 Sept 2024 at 09:36, Mahadevan P <quic_mahap@xxxxxxxxxxx> wrote: > > > On 9/12/2024 1:30 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 12, 2024 at 12:44:37PM GMT, Mahadevan wrote: > >> Add mdss and mdp DT nodes for SA8775P. > >> > >> Signed-off-by: Mahadevan <quic_mahap@xxxxxxxxxxx> > >> --- > >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 85 +++++++++++++++++++++++++++ > >> 1 file changed, 85 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > >> index 67ba124d20f8..d5d8e02fdb29 100644 > >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > >> @@ -6,6 +6,7 @@ > >> #include <dt-bindings/interconnect/qcom,icc.h> > >> #include <dt-bindings/interrupt-controller/arm-gic.h> > >> #include <dt-bindings/clock/qcom,rpmh.h> > >> +#include <dt-bindings/clock/qcom,sa8775p-dispcc.h> > >> #include <dt-bindings/clock/qcom,sa8775p-gcc.h> > >> #include <dt-bindings/clock/qcom,sa8775p-gpucc.h> > >> #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> > >> @@ -2937,6 +2938,90 @@ camcc: clock-controller@ade0000 { > >> #power-domain-cells = <1>; > >> }; > >> > >> + mdss0: display-subsystem@ae00000 { > > Is there going to be mdss1? > > > Currently we don't have plan to enable mdss1. Do we need to rename label > to just "mdss" in that case? No, please keep mdss0. Just explain what you are doing in the commit message. -- With best wishes Dmitry