On 9/23/2024 2:02 AM, Krzysztof Kozlowski wrote:
On Sun, Sep 22, 2024 at 05:03:44PM +0530, Md Sadre Alam wrote:
Document the QPIC-SPI-NAND flash controller present in the IPQ SoCs.
It can work both in serial and parallel mode and supports typical
SPI-NAND page cache operations.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
---
Change in [v10]
* No change
...
+title: Qualcomm QPIC NAND controller
+
+maintainers:
+ - Md sadre Alam <quic_mdalam@xxxxxxxxxxx>
+
+description:
+ The QCOM QPIC-SPI-NAND flash controller is an extended version of
+ the QCOM QPIC NAND flash controller. It can work both in serial
+ and parallel mode. It supports typical SPI-NAND page cache
+ operations in single, dual or quad IO mode with pipelined ECC
+ encoding/decoding using the QPIC ECC HW engine.
+
+allOf:
+ - $ref: /schemas/spi/spi-controller.yaml#
+
+properties:
+ compatible:
+ enum:
+ - qcom,spi-qpic-snand
Recently it turned out that Qualcomm generic compatibles are not
generic... That was odd, but to me it is a clear signal that something
should not be called generic if it is not generic enough.
Please switch to soc-specific compatibles (and drop my reviewed-by, so
this will appear in my review queue).
Ok , will add in next revision.
Best regards,
Krzysztof
