On Thu, Sep 19, 2024 at 12:51:13AM -0700, Amit Sunil Dhamne wrote: > This commit adds the following properties: > * sink-wait-cap-time-ms > * ps-source-off-time-ms > * cc-debounce-time-ms > > This is to enable setting of platform/board specific timer values as > these timers have a range of acceptable values. What's acceptable? Put that in constraints for the properties. > > Signed-off-by: Amit Sunil Dhamne <amitsd@xxxxxxxxxx> > --- > .../bindings/connector/usb-connector.yaml | 32 ++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index fb216ce68bb3..5efa4ea3c41c 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -253,6 +253,33 @@ properties: > > additionalProperties: false > > + sink-wait-cap-time-ms: > + description: Represents the max time in ms that USB Type-C port (in sink > + role) should wait for the port partner (source role) to send source caps. > + SinkWaitCap timer starts when port in sink role attaches to the source. > + This timer will stop when sink receives PD source cap advertisement before > + timeout in which case it'll move to capability negotiation stage. A > + timeout leads to a hard reset message by the port. If no value is set for > + this property then the driver assumes a default value of PD_T_SINK_WAIT_CAP > + (defined in include/linux/usb/pd.h). Express default as "default: N". Sorry, defines don't work here.