On 29/08/2024 09:07, Abel Vesa wrote: > On 24-06-27 16:24:24, Pengfei Li wrote: >> 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to >> indicate the number of clocks, but it is not part of the ABI, so >> it should be moved to clk driver. >> > > Right, why? > > All other providers have been using the _CLK_END from the bindings > header. What is so special about this ? AFAICT, nothing. Because usually we do no consider number of clocks as an ABI. For starters it does no really appear in DTS. But what's more important - new clocks are described later, which contradicts this define. So either this is an ABI or it is not. If it is, you are not allowed to add any new clock. If it is not, then this should have never been part of bindings. We did the same (removal of END/NUM macros) for several other platforms already. Best regards, Krzysztof
