On 19/09/2024 22:14, Guenter Roeck wrote:
On 9/19/24 08:02, Chanh Nguyen wrote:
On 19/09/2024 17:39, Krzysztof Kozlowski wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external
sender. Please be mindful of safe email handling and proprietary
information protection practices.]
On 19/09/2024 11:43, Chanh Nguyen wrote:
+properties:
+ compatible:
+ const: onnn,adt7462
+
+ reg:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
How would this work? 'resets' generally is used for on-chip devices
and
a reset controller. That doesn't exist at the board level. A
standalone
device typically uses a GPIO lines if there's a s/w controlled reset.
That would be the 'reset-gpios' property.
Thank Rob for your comments! The ADT7462 includes an active low reset
pin (Pin #14).
I'll change 'resets' into the 'reset-gpios' property.
The example in the binding will be
The question how did it work in the first place is still valid... I
think we might benefit from asking people to post their upstreamed DTS.
Otherwise we will take broken or half-baked bindings, because we never
saw the bigger picture. :(
Thank Krzysztof,
I saw the ADT7462 includes an active low reset pin (Pin #14) to reset
device via I/O pin. So, I introduced a reset property follow the
device datasheet.
But the adt7462 driver has not yet implemented this property. My
platform also doesn't design this pin on board, so I don't need it at
least now.
Anyway, I hope Rob, Guenter and Krzysztof can give me advice on
whether I should add this property to the binding?
Not from my perspective, and I won't let you add it to the driver unless
you can
actually test it. Really, this is such an old chip that it would make
more sense
to just leave its driver alone unless there is a problem with it. Why
didn't you
just add the chip to the list of trivial devices ?
No Guenter, I don't think I'll change or update anythings to the adt7462
driver. The driver is working fine for me.
I just wonder about this property in the dt-binding. It seems I
shouldn't add the reset property to the dt-binding.
"Why didn't you just add the chip to the list of trivial devices ?" =>
Awesome, I just learned about the trivial-devices.yaml from your
suggestion
(https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/trivial-devices.yaml),
this is thing that I'm finding for the adt7462 binding. Perfect!
I'm looking forward to hearing Rob and Krzysztof's idea. If nothing
else, I'll add this chip to the list of trivial devices in the patch v2.
Thanks,
Chanh
Guenter
