Hi Neil, On Wed, Sep 11, 2024 at 5:09 PM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > > Convert the Amlogic Meson8, Meson8b and Meson8m2 Clock and > Reset Controller to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> Thank you for working on this! First of all this patch is: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Do you want me to send a patch to document the "amlogic,meson-hhi-sysctrl" compatible string next? We either have to update Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml or create a similar binding file for the older SoCs. Also I think when documenting that compatible string we'll have to add per-SoC compatibles as I think this generic one is not enough. Best regards, Martin