On 12/09/2024 15:28, Oleh Kuzhylnyi wrote: > Add documentation for the Hynitron CST816X touchscreen bindings. > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Drop. This is significantly different binding. Like 100% rewrite. > Signed-off-by: Oleh Kuzhylnyi <kuzhylol@xxxxxxxxx> > --- > > Changes in v7: > - Introduce the gestures field along with its sub-fields > - Make reset-gpio property optional > - Extend main description > - Remove "touchscreen" reference > > Changes in v6: > - Fix minor tweak adviced by Krzysztof: > - Move additionalProperties field after required > > Changes in v5: > - No code changes > > Changes in v4: > - Add Conor's Dooley "Reviewed-by" tag > > Changes in v3: > - Rename filename to hynitron,cst816s.yaml > - Update description with display details > > Changes in v2: > - Apply pin definitions and DT headers > - Use generic name for DT node > - Drop status field > > .../input/touchscreen/hynitron,cst816s.yaml | 126 ++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > new file mode 100644 > index 000000000000..99ac29da7a5a > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml > @@ -0,0 +1,126 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/hynitron,cst816s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hynitron CST816S Touchscreen controller > + > +description: > + The CST816S is a touchscreen controller from Hynitron, which supports gesture > + recognition for swipe directions, tap, and long-press actions. This binding > + document defines the necessary properties for integrating the CST816S with > + a Linux system. > + > +maintainers: > + - Oleh Kuzhylnyi <kuzhylol@xxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - hynitron,cst816s > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + description: > + Optional GPIO line used to reset the touchscreen controller. > + optional: true ??? Please test your patches before sending. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof