Re: [PATCH v4 2/2] iio: imu: Add i2c driver for bmi270 imu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 14, 2024 at 02:27:34PM GMT, Jonathan Cameron wrote:
> On Thu, 12 Sep 2024 17:07:19 -0400
> Alex Lanzano <lanzano.alex@xxxxxxxxx> wrote:
> 
> > Add initial i2c support for the Bosch BMI270 6-axis IMU.
> > Provides raw read access to acceleration and angle velocity measurements
> > via iio channels. Device configuration requires firmware provided by
> > Bosch and is requested and load from userspace.
> > 
> > Signed-off-by: Alex Lanzano <lanzano.alex@xxxxxxxxx>
> 
> Hi Alex,
> 
> A bunch of fairly minor stuff so I've just tweaked it whilst applying rather
> than wasting time on going around again.
> 
> I also changed a few line wraps to keep lines a bit shorter.
> Where it doesn't hurt readability 80 chars is still my preference for IIO.
> 
> The diff of the tweaks I made is as follows. Shout if I messed anything up!
> 

Looks good! I agree with all the changes. Thanks again for the review
and cleaning it up for me.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux