On Wed, Sep 11, 2024 at 07:35:35PM +0200, Danilo Krummrich wrote: > On Wed, Sep 11, 2024 at 04:56:14PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 11, 2024 at 07:57:18PM +0530, Ayush Singh wrote: > > > +/// An identifier for Platform devices. > > > +/// > > > +/// Represents the kernel's [`struct of_device_id`]. This is used to find an appropriate > > > +/// Platform driver. > > > +/// > > > +/// [`struct of_device_id`]: srctree/include/linux/mod_devicetable.h > > > +pub struct DeviceId(&'static CStr); > > > + > > > +impl DeviceId { > > > > <snip> > > > > I appreciate posting this, but this really should go on top of the > > device driver work Danilo Krummrich has been doing. > > If everyone agrees, I'd offer to just provide platform device / driver > abstractions with my next patch series. This way you don't need to worry > about aligning things with the rest of the abstractions yourself and throughout > potential further versions of the series. Covering platform device/driver abstractions in the same series would be appreciated from asahi side. It hopefully results in earlier merge since it avoids a dependency on the device driver abstractions. Feel free to reach out to me for an earlier preview / rabsing of the asahi driver. https://github.com/AsahiLinux/linux/tree/bits/210-gpu has all relevant rust changes from 6.11-rc but I plan to rebase onto 6.11 in the next days and possibly import changes from 6.12-rc* / rust-next. Thanks Janne