On Fri, Sep 06, 2024 at 04:44:44PM +0530, Kamlesh Gurudasani wrote: > > Just wanted to confirm, if this is being rejected primarily because > 1. there is no in-kernel user for crc64-iso3309 > 2. or poor performance benefit of using it from userspace Essentially we don't want to add every random algorithm to the crypto API because we may end up having to maintain them long after the users have disappeared. For a special-purpose algorithm like this, it's perfectly fine to have a custom driver to be made so that your user-space app can access the hardware. > The context for asking is that we have another superset IP known as MCRC > (this one is MCRC64), which supports crc8/16/32/64(iso-3309). > > That IP has working DMA and will give good offloading numbers. > > We are planning to send drivers for crc8/16/32 for MCRC > 1.should I put efforts for crc64-iso3309 as well or > 2.drop the crc64-iso3309 and send only for remaining > crc8/16/32(standard algorithms with already in-kernel user). > > All our devices either have MCRC or MCRC64. Do any existing kernel users benefit sufficiently from these algorithms being offloaded? If no then there is no need to bother. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
