On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > + > +#include <linux/device.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/platform_device.h> > +#include <linux/soc/adi/adsp-gpio-port.h> > +#include "gpiolib.h" > + > +static int adsp_gpio_direction_input(struct gpio_chip *chip, unsigned > int offset) > +{ > + struct adsp_gpio_port *port = to_adsp_gpio_port(chip); > + > + __adsp_gpio_writew(port, BIT(offset), ADSP_PORT_REG_DIR_CLEAR); > + __adsp_gpio_writew(port, BIT(offset), ADSP_PORT_REG_INEN_SET); > + return 0; What is the purpose of these __adsp_gpio_writew() in a global header? Can't those be moved into this file directly? > \ No newline at end of file Whitespace damage? Arnd