> -----Original Message-----
> From: Delphine_CC_Chiu/WYHQ/Wiwynn
> Sent: Friday, September 13, 2024 10:08 AM
> To: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>;
> Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> <joel@xxxxxxxxx>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
>
>
>
> > -----Original Message-----
> > From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> > Sent: Thursday, September 12, 2024 10:11 AM
> > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> > patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> > <joel@xxxxxxxxx>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > pca9506 for CPLD IOE
> >
> > [External Sender]
> >
> > [External Sender]
> >
> > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> > >
> > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > boards.
> > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> >
> > I think it might be best if you add your own compatible to the list in
> > the gpio-pca95xx binding just in case there are some behavioural
> > quirks of your CPLD implementation? Not sure if this should be
> > "facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from
> > there you can specify
> >
> > compatible = "facebook,pca9506", "nxp,pca9506";
> >
> > This allows you to add the quirks to the driver as required in the
> > future through the more-specific compatible.
> >
> > Andrew
>
> Hi Andrew,
>
> Thanks for the review.
> I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of
> patches.
Hi Andrew,
I tried to add "facebook,pca9506" in the compatible list of gpio-pca95xx binding
and add compatible = "facebook,pca9506", "nxp,pca9506" but got following failed
messages:
gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
['facebook,pca9506', 'nxp,pca9506'] is too long
'diodes,pi4ioe5v6534q' was expected
'nxp,pcal6534' was expected
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
Would like to ask do you have any suggestions? Thanks.
