On 9/12/24 01:34, Greg Kroah-Hartman wrote:
On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote:
On 9/11/24 20:28, Greg Kroah-Hartman wrote:
On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote:
- GPS3 Click is a UART MikroBUS addon Board
Link: https://www.mikroe.com/gps-3-click
Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
---
addon_boards/mikrobus/Makefile | 1 +
addon_boards/mikrobus/mikroe-1714.dtso | 28 ++++++++++++++++++++++++++++
Odd top-level directory for the kernel, are you sure this is correct?
thanks,
greg k-h
Well, it is kinda a temporary location, since well, I could not find a good
place for board overlays but a top-level location seems better than putting
them in any arch specific location. I am open to moving them to a more
suitable location if we have one.
top-level location is not ok for something so tiny and "special". Just
put it where all other dtso files go.
thanks,
greg k-h
So here are the directories where dtso files currently go:
❯ find . -type f -name "*.dtso" -printf "%h\n" | sort -u
./arch/arm64/boot/dts/amlogic
./arch/arm64/boot/dts/freescale
./arch/arm64/boot/dts/mediatek
./arch/arm64/boot/dts/qcom
./arch/arm64/boot/dts/renesas
./arch/arm64/boot/dts/rockchip
./arch/arm64/boot/dts/ti
./arch/arm64/boot/dts/xilinx
./arch/arm/boot/dts/nxp/imx
./arch/arm/boot/dts/ti/omap
./drivers/clk
./drivers/of
./drivers/of/unittest-data
Out of these, `drivers/of` and `drivers/of/unittest-data` contain
unittest dtso, so probably not the place.
And the `arch/arm` and `arch/arm64` are for arch specific stuff.
MikroBUS is supported in RISC-V boards as well (BeagleV-Ahead). So
probably not the correct location either.
Maybe something like `arch/common/addon_boards` would be better?
Ayush Singh
