Re: [PATCH v8 0/8] Add QPIC SPI NAND driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/10/2024 1:11 PM, Miquel Raynal wrote:
Hi,

    >>       I have addressed your comments to v6 and further posted till v8.
       Could you please let me know if this is fine.
       and how to get this merged ?

There are still kernel test robot reports, so this means there are
issues in your code that I don't need to point out explicitly, but I am
actively waiting for them to be fixed.

I have fixed most of the sparse warnings after converting __le32 to u32.
However am not able to address the following sparse warnings

	drivers/mtd/nand/raw/qcom_nandc.c:1401:29: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1587:30: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1588:31: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1589:34: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:2479:47: sparse:    got restricted __le32 [usertype]
	drivers/mtd/nand/raw/qcom_nandc.c:2480:47: sparse:    got restricted __le32 [usertype]
	drivers/mtd/nand/raw/qcom_nandc.c:2616:25: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:2672:32: sparse: warning: cast to restricted __le32

The rule is: you cannot add new warnings.

For existing warnings in the driver, I'd anyway advise to solve them.
Without the actual code I cannot help.
I have fixed all the warnings and posted next revision.

Thanks,
Miquèl




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux