Re: [PATCH 05/13] arm64: dts: mediatek: mt8188: Add missing GCE clock names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 09/09/24 13:14, Fei Shao ha scritto:
Add the missing clock-names property for GCE nodes to fix errors from
`make CHECK_DTBS=y mediatek/mt8188-evb.dtb`.

I've sent a patch [1] relaxing the requirement for clock-names in the binding.
There's no reason to make clock-names mandatory, as there is and there always
will be one single clock for each GCE mailbox - and also the driver is not
trying to get the clock by name, but rather gets the clock at index 0 anyway.

Please drop this patch.

Cheers,
Angelo

[1]: https://lore.kernel.org/all/20240911104327.123602-1-angelogioacchino.delregno@xxxxxxxxxxxxx/


Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx>
---

  arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
index 445d30eee2a1..2900d78b7ceb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
@@ -1316,6 +1316,7 @@ gce0: mailbox@10320000 {
  			interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH 0>;
  			#mbox-cells = <2>;
  			clocks = <&infracfg_ao CLK_INFRA_AO_GCE>;
+			clock-names = "gce";
  		};
gce1: mailbox@10330000 {
@@ -1324,6 +1325,7 @@ gce1: mailbox@10330000 {
  			interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH 0>;
  			#mbox-cells = <2>;
  			clocks = <&infracfg_ao CLK_INFRA_AO_GCE2>;
+			clock-names = "gce";
  		};
scp: scp@10500000 {





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux