On Thu, Mar 12, 2015 at 04:45:50PM +0100, Jens Thiele wrote: > This commit introduces two new optional device-tree properties: > "tp-sensitive-adjust": adjust sensitivity of pen down detection > "filter-type": select median and averaging filter > > The previous fixed defaults, didn't work well for the Olimex > A13-LCD10TS (I have). > > Signed-off-by: Jens Thiele <karme@xxxxxxxx> > --- > .../devicetree/bindings/input/touchscreen/sun4i.txt | 19 +++++++++++++++++-- > drivers/input/touchscreen/sun4i-ts.c | 17 +++++++++++++---- > 2 files changed, 30 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > index 433332d..c93edfa 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > +++ b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt > @@ -8,8 +8,20 @@ Required properties: > - #thermal-sensor-cells: shall be 0 > > Optional properties: > - - allwinner,ts-attached: boolean indicating that an actual touchscreen is > - attached to the controller > + - allwinner,ts-attached : boolean indicating that an actual touchscreen > + is attached to the controller > + - allwinner,tp-sensitive-adjust : integer (4 bits) > + adjust sensitivity of pen down detection > + between 0 (least sensitive) and 15 > + (defaults to 15) > + - allwinner,filter-type : integer (2 bits) > + select median and averaging filter > + samples used for median / averaging filter > + 0: 4/2 > + 1: 5/3 > + 2: 8/4 > + 3: 16/8 > + (defaults to 1) You shouldn't rely on any bits length in your binding. And this looks really more of a configuration option, and would be better exposed through sysfs. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature