Just two nits to look into once you get to fix up all the smaller issues. NeilBrown schreef op wo 18-03-2015 om 16:58 [+1100]: > --- /dev/null > +++ b/drivers/tty/slave/Kconfig > @@ -0,0 +1,7 @@ > +menuconfig TTY_SLAVE > + tristate "TTY slave devices" > + depends on OF > + help > + Devices which attach via a uart, but need extra > + driver support for power management etc. > + This blank line makes "git am" whine: "new blank line at EOF". > --- /dev/null > +++ b/drivers/tty/slave/tty_slave_core.c [...] This file doesn't have a MODULE_LICENSE() macro. So I think that, if this driver is built as a module and loaded, kernel/module.c will set its license to "unspecified" and taint the kernel. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html