On Mon, Sep 09, 2024 at 04:25:45PM +0530, Mohammad Rafi Shaik wrote: > diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h > index 5e0dd47a0412..264450763bab 100644 > --- a/include/linux/soundwire/sdw.h > +++ b/include/linux/soundwire/sdw.h > @@ -857,6 +857,8 @@ struct sdw_master_ops { > (struct sdw_bus *bus); > int (*set_bus_conf)(struct sdw_bus *bus, > struct sdw_bus_params *params); > + int (*set_master_channel_map)(struct sdw_bus *bus, int *ch_mask, > + unsigned int port_num); At the very least this needs some kernel doc to explain what the new callback is for, I think also the commit message could use some work to help us understand the purpose here. Thanks, Charles