On Sat, Sep 07, 2024 at 04:47:43PM GMT, Jonathan Cameron wrote: > On Fri, 6 Sep 2024 12:52:50 -0400 > Alex Lanzano <lanzano.alex@xxxxxxxxx> wrote: > > > Add device tree bindings for the bmi270 IMU > > > > Signed-off-by: Alex Lanzano <lanzano.alex@xxxxxxxxx> > Hi Alex > > One totally trivial thing inline. If nothing comes up in > driver I'll tidy this up whilst applying > > Jonathan > Will apply in v3! > > --- > > .../bindings/iio/imu/bosch,bmi270.yaml | 77 +++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > new file mode 100644 > > index 000000000000..7de35b9bfa2e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > @@ -0,0 +1,77 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/imu/bosch,bmi270.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Bosch BMI270 6-Axis IMU > > + > > +maintainers: > > + - Alex Lanzano <lanzano.alex@xxxxxxxxx> > > + > > +description: | > > + BMI270 is a 6-axis inertial measurement unit that can measure acceleration and > > + angular velocity. The sensor also supports configurable interrupt events such > > + as motion, step counter, and wrist motion gestures. The sensor can communicate > > + I2C or SPI. > > + https://www.bosch-sensortec.com/products/motion-sensors/imus/bmi270/ > > + > > +properties: > > + compatible: > > + const: bosch,bmi270 > > + > > + reg: > > + maxItems: 1 > > + > > + vdd-supply: true > > + vddio-supply: true > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + enum: > > + - INT1 > > + - INT2 > > + > > + drive-open-drain: > > + description: > > + set if the specified interrupt pin should be configured as > > pins > > Even if they are configurable separately we've previously argued that > it is very unlikely a board designer would want one open drain > and the other push-pull. So simply making the description plural > should be enough. > Will Fix in v3! > > + open drain. If not set, defaults to push-pull. > > + > > + mount-matrix: > > + description: > > + an optional 3x3 mounting rotation matrix. > > + > > +required: > > + - compatible > > + - reg > > + - vdd-supply > > + - vddio-supply > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + imu@68 { > > + compatible = "bosch,bmi270"; > > + reg = <0x68>; > > + vdd-supply = <&vdd>; > > + vddio-supply = <&vddio>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <16 IRQ_TYPE_EDGE_RISING>; > > + interrupt-names = "INT1"; > > + }; > > + }; Thanks so much for the review! Best regards, Alex
